Fix memory leak in GStreamer caps parsing#3692
Merged
meee1 merged 1 commit intoArduPilot:masterfrom Apr 13, 2026
Merged
Conversation
Contributor
Author
|
@meee1 when you have a time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a severe unmanaged memory leak inside the GStreamer video processing pipeline (
ExtLibs\Utilities\GStreamer.cs).For every video frame pulled from the
appsink, the code was callingNativeMethods.gst_caps_to_string(caps_s). This native GStreamer C function allocates a new character array (gchar*) that must be explicitly freed usingg_free(). However, the C# P/Invoke wrapper only marshaled the pointer into a managed string but never freed the underlying native pointer. Because this was called inside the continuous frame loop, it resulted in a persistent and aggressive unmanaged memory leak.Since the generated
capsstringwas completely unused by the application, the call has been commented out to immediately resolve the leak.The Memory Leak Impact
Because this unmanaged allocation occurred per frame, the leak scaled directly with the stream's frame rate. For a standard 720p video stream running at 60 FPS, the leak estimate looks like this:
video/x-raw, format=(string)BGRx, width=(int)1280, height=(int)720, framerate=(fraction)60/1) translates to roughly ~150 bytes.Over long flight sessions typical for Ground Control Stations, this continuous background allocation eventually leads to high memory footprints and potential out-of-memory (OOM) crashes.